8 Jan
2025
8 Jan
'25
1:17 p.m.
Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85716?usp=email )
Change subject: ec/starlabs/merlin: Only include battery ACPI for systems with a battery ......................................................................
Patch Set 6:
(1 comment)
File src/ec/starlabs/merlin/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/85716/comment/b1984ed5_515d8697?usp... : PS5, Line 137: #if CONFIG
it seems that the convention when using `#if CONFIG` in ASL code is to not indent it at all, so I'd […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85716?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I381714887f4319d8e1a25c1e493ba03631cbf082
Gerrit-Change-Number: 85716
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Wed, 08 Jan 2025 11:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com