Hello Kyösti Mälkki, Aaron Durbin, Patrick Rudolph, Piotr Król, Julius Werner, Patrick Rudolph, build bot (Jenkins), Philipp Hug, Werner Zeh, Alexander Couzens, ron minnich, David Guckian, Felix Held, Vanessa Eusebio, Huang Jin, Lee Leahy, Jonathan Neuschäfer, Philipp Deppenwiese, Damien Zammit, David Guckian, Michał Żygowski,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32023
to look at the new patch set (#34).
Change subject: src: Use 'include <stdlib.h>' when appropriate ......................................................................
src: Use 'include <stdlib.h>' when appropriate
Also add some missing includes spotted by Jenkins, and replace <{stdint,stddef}.h> by <types.h> when both are included.
Used command: diff <(git grep -l '#include <stdlib.h>' -- src/) <(git grep -l \ '(min|max|memalign|malloc|free)' -- src/) |grep -F '<'
Change-Id: Id89751c600bad2ddb4b5aa9822adc5c5097787aa Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/armv7/exception.c M src/arch/arm/armv7/mmu.c M src/arch/arm/cpu.c M src/arch/arm/eabi_compat.c M src/arch/arm/include/armv4/arch/cache.h M src/arch/arm/include/armv7/arch/cache.h M src/arch/arm64/armv8/exception.c M src/arch/arm64/armv8/mmu.c M src/arch/arm64/fit_payload.c M src/arch/arm64/include/armv8/arch/cache.h M src/arch/riscv/misaligned.c M src/arch/x86/acpi_device.c M src/arch/x86/acpigen_dsm.c M src/arch/x86/cbmem.c M src/arch/x86/include/arch/acpigen.h M src/arch/x86/include/arch/early_variables.h M src/arch/x86/include/arch/ebda.h M src/arch/x86/include/smm.h M src/arch/x86/mmap_boot.c M src/commonlib/mem_pool.c M src/commonlib/region.c M src/commonlib/storage/bouncebuf.c M src/commonlib/storage/bouncebuf.h M src/commonlib/storage/sdhci.c M src/commonlib/storage/sdhci_adma.c M src/device/i2c_bus.c M src/device/oprom/yabel/vbe.c M src/device/pnp_device.c M src/drivers/aspeed/ast2050/ast2050.c M src/drivers/emulation/qemu/bochs.c M src/drivers/i2c/rtd2132/rtd2132.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/intel/gma/intel_ddi.c M src/drivers/net/ne2k.c M src/drivers/parade/ps8625/ps8625.c M src/drivers/sil/3114/sil_sata.c M src/drivers/uart/uart8250io.c M src/drivers/vpd/vpd.c M src/drivers/vpd/vpd_cbmem.c M src/drivers/xgi/common/xgi_coreboot.h M src/ec/google/chromeec/ec_lpc.c M src/ec/google/chromeec/vstore.c M src/ec/google/wilco/chip.c M src/include/bootstate.h M src/include/device/i2c_bus.h M src/include/string.h M src/lib/bootmem.c M src/lib/cbfs.c M src/lib/coreboot_table.c M src/lib/fit.c M src/lib/fit_payload.c M src/lib/hardwaremain.c M src/lib/imd.c M src/lib/imd_cbmem.c M src/lib/prog_loaders.c M src/lib/rmodule.c M src/lib/selfboot.c M src/lib/thread.c M src/mainboard/amd/bettong/BiosCallOuts.c M src/mainboard/amd/db-ft3b-lc/BiosCallOuts.c M src/mainboard/amd/gardenia/BiosCallOuts.c M src/mainboard/amd/inagua/BiosCallOuts.c M src/mainboard/amd/inagua/buildOpts.c M src/mainboard/amd/lamar/BiosCallOuts.c M src/mainboard/amd/olivehill/BiosCallOuts.c M src/mainboard/amd/olivehill/buildOpts.c M src/mainboard/amd/olivehillplus/BiosCallOuts.c M src/mainboard/amd/parmer/BiosCallOuts.c M src/mainboard/amd/parmer/buildOpts.c M src/mainboard/amd/persimmon/BiosCallOuts.c M src/mainboard/amd/persimmon/buildOpts.c M src/mainboard/amd/south_station/BiosCallOuts.c M src/mainboard/amd/south_station/buildOpts.c M src/mainboard/amd/thatcher/BiosCallOuts.c M src/mainboard/amd/thatcher/buildOpts.c M src/mainboard/amd/union_station/BiosCallOuts.c M src/mainboard/amd/union_station/buildOpts.c M src/mainboard/asrock/e350m1/BiosCallOuts.c M src/mainboard/asrock/e350m1/buildOpts.c M src/mainboard/asrock/imb-a180/BiosCallOuts.c M src/mainboard/asrock/imb-a180/buildOpts.c M src/mainboard/asus/am1i-a/BiosCallOuts.c M src/mainboard/asus/am1i-a/buildOpts.c M src/mainboard/asus/f2a85-m/BiosCallOuts.c M src/mainboard/asus/f2a85-m/buildOpts.c M src/mainboard/bap/ode_e20XX/BiosCallOuts.c M src/mainboard/bap/ode_e20XX/buildOpts.c M src/mainboard/bap/ode_e21XX/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/buildOpts.c M src/mainboard/biostar/am1ml/BiosCallOuts.c M src/mainboard/biostar/am1ml/buildOpts.c M src/mainboard/cavium/cn8100_sff_evb/romstage.c M src/mainboard/elmex/pcm205400/BiosCallOuts.c M src/mainboard/elmex/pcm205400/buildOpts.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/gizmosphere/gizmo/BiosCallOuts.c M src/mainboard/gizmosphere/gizmo/buildOpts.c M src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c M src/mainboard/gizmosphere/gizmo2/buildOpts.c M src/mainboard/hp/abm/BiosCallOuts.c M src/mainboard/hp/abm/buildOpts.c M src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c M src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/jetway/nf81-t56n-lf/BiosCallOuts.c M src/mainboard/jetway/nf81-t56n-lf/buildOpts.c M src/mainboard/lenovo/g505s/BiosCallOuts.c M src/mainboard/lenovo/g505s/buildOpts.c M src/mainboard/lippert/frontrunner-af/BiosCallOuts.c M src/mainboard/lippert/frontrunner-af/buildOpts.c M src/mainboard/lippert/frontrunner-af/mainboard.c M src/mainboard/lippert/toucan-af/BiosCallOuts.c M src/mainboard/lippert/toucan-af/buildOpts.c M src/mainboard/lippert/toucan-af/mainboard.c M src/mainboard/msi/ms7721/BiosCallOuts.c M src/mainboard/msi/ms7721/buildOpts.c M src/mainboard/opencellular/elgon/romstage.c M src/mainboard/pcengines/apu1/BiosCallOuts.c M src/mainboard/pcengines/apu1/buildOpts.c M src/mainboard/pcengines/apu2/BiosCallOuts.c M src/mainboard/roda/rk9/mainboard.c M src/northbridge/amd/agesa/family14/dimmSpd.c M src/northbridge/amd/agesa/family14/northbridge.c M src/northbridge/amd/agesa/family15tn/dimmSpd.c M src/northbridge/amd/agesa/family16kb/dimmSpd.c M src/northbridge/amd/pi/00660F01/dimmSpd.c M src/northbridge/intel/e7505/northbridge.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/haswell/minihd.c M src/northbridge/intel/nehalem/early_init.c M src/northbridge/intel/pineview/early_init.c M src/northbridge/intel/pineview/raminit.c M src/northbridge/intel/sandybridge/finalize.c M src/northbridge/intel/sandybridge/raminit_common.c M src/security/tpm/tspi/tspi.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/vboot/secdata_mock.c M src/security/vboot/secdata_tpm.c M src/soc/amd/common/block/spi/fch_spi_flash.c M src/soc/amd/stoneyridge/BiosCallOuts.c M src/soc/amd/stoneyridge/northbridge.c M src/soc/amd/stoneyridge/sm.c M src/soc/cavium/cn81xx/cbmem.c M src/soc/cavium/cn81xx/spi.c M src/soc/intel/baytrail/gfx.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/finalize.c M src/soc/intel/broadwell/igd.c M src/soc/intel/broadwell/me.c M src/soc/intel/broadwell/me_status.c M src/soc/intel/broadwell/minihd.c M src/soc/intel/broadwell/pei_data.c M src/soc/intel/broadwell/ramstage.c M src/soc/intel/broadwell/romstage/cpu.c M src/soc/intel/broadwell/romstage/power_state.c M src/soc/intel/broadwell/romstage/systemagent.c M src/soc/intel/broadwell/serialio.c M src/soc/intel/broadwell/systemagent.c M src/soc/intel/cannonlake/finalize.c M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/acpi_wake_source.c M src/soc/intel/common/block/fast_spi/fast_spi.c M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/smbios.c M src/soc/intel/denverton_ns/csme_ie_kt.c M src/soc/intel/denverton_ns/smihandler.c M src/soc/intel/denverton_ns/systemagent.c M src/soc/intel/icelake/finalize.c M src/soc/intel/quark/i2c.c M src/soc/intel/skylake/elog.c M src/soc/intel/skylake/me.c M src/soc/intel/skylake/pmutil.c M src/soc/mediatek/mt8173/ddp.c M src/soc/mediatek/mt8173/include/soc/gpio.h M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra124/display.c M src/soc/nvidia/tegra124/dma.c M src/soc/nvidia/tegra124/include/soc/clock.h M src/soc/nvidia/tegra124/sdram.c M src/soc/nvidia/tegra124/sdram_lp0.c M src/soc/nvidia/tegra124/sor.c M src/soc/nvidia/tegra124/verstage.c M src/soc/nvidia/tegra210/clock.c M src/soc/nvidia/tegra210/dma.c M src/soc/nvidia/tegra210/include/soc/clock.h M src/soc/nvidia/tegra210/include/soc/mipi-phy.h M src/soc/nvidia/tegra210/mipi-phy.c M src/soc/nvidia/tegra210/sdram.c M src/soc/nvidia/tegra210/sdram_lp0.c M src/soc/nvidia/tegra210/sor.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq40xx/lcc.c M src/soc/qualcomm/ipq40xx/qup.c M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/i2c.c M src/soc/qualcomm/ipq806x/lcc.c M src/soc/qualcomm/ipq806x/qup.c M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/common/i2c.c M src/soc/rockchip/common/include/soc/edp.h M src/soc/rockchip/common/pwm.c M src/soc/rockchip/common/rk808.c M src/soc/rockchip/common/vop.c M src/soc/rockchip/rk3288/clock.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/hdmi.c M src/soc/rockchip/rk3288/include/soc/hdmi.h M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3288/tsadc.c M src/soc/rockchip/rk3399/clock.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/include/soc/mipi.h M src/soc/rockchip/rk3399/mipi.c M src/soc/rockchip/rk3399/saradc.c M src/soc/rockchip/rk3399/soc.c M src/soc/rockchip/rk3399/tsadc.c M src/soc/samsung/exynos5250/alternate_cbfs.c M src/soc/samsung/exynos5250/clock.c M src/soc/samsung/exynos5250/cpu.c M src/soc/samsung/exynos5250/fb.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5420/alternate_cbfs.c M src/soc/samsung/exynos5420/clock.c M src/soc/samsung/exynos5420/cpu.c M src/soc/samsung/exynos5420/dp.c M src/soc/samsung/exynos5420/dp_lowlevel.c M src/soc/samsung/exynos5420/pinmux.c M src/soc/samsung/exynos5420/smp.c M src/soc/samsung/exynos5420/spi.c M src/soc/sifive/fu540/clock.c M src/southbridge/amd/agesa/hudson/spi.c M src/southbridge/intel/bd82x6x/me_status.c M src/southbridge/intel/common/smbus.c M src/southbridge/intel/lynxpoint/me_status.c M src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c M src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c M src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c M src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c 249 files changed, 97 insertions(+), 299 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/32023/34