Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35224 )
Change subject: soc/intel/common/block/cse: Add helper function heci_send_receive ......................................................................
Patch Set 5:
(32 comments)
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 462: size_t *rcv_sz)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 462: size_t *rcv_sz)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 464: if (!heci_send(snd_msg, snd_sz, BIOS_HOST_ADDR, HECI_MKHI_ADDR)) {
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 464: if (!heci_send(snd_msg, snd_sz, BIOS_HOST_ADDR, HECI_MKHI_ADDR)) {
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 465: printk(BIOS_ERR, "Heci Send Failed\n");
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 465: printk(BIOS_ERR, "Heci Send Failed\n");
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 466: goto failed;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 466: goto failed;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 467: }
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 467: }
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 469: if (rcv_msg != NULL) {
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 469: if (rcv_msg != NULL) {
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 470: if (!heci_receive(rcv_msg, rcv_sz)) {
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 470: if (!heci_receive(rcv_msg, rcv_sz)) {
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 471: printk(BIOS_ERR, "Heci receive Failed\n");
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 471: printk(BIOS_ERR, "Heci receive Failed\n");
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 472: goto failed;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 472: goto failed;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 473: }
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 473: }
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 474: }
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 474: }
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 476: return 1;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 476: return 1;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 479: return 0;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 479: return 0;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... PS2, Line 462:
Done
Done
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... PS2, Line 466: goto failed;
Done
Done
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... PS2, Line 472: goto failed;
Done
Done
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... PS2, Line 42:
Done
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 47: size_t *rcv_sz);
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35224/1/src/soc/intel/common/block/... PS1, Line 47: size_t *rcv_sz);
please, no spaces at the start of a line
Done