Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44054 )
Change subject: mb/google/dedede: Update CPU critical temperature
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44054/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44054/1//COMMIT_MSG@16
PS1, Line 16: None
Also I believe Tim meant to ask the bug for tracking purposes.
We have set TCC offset to 10W, in this case TCC initiates the thermal throttling at (TjMax-offset=95C), so this prevents junction temp to reach TjMax. Also, we have DPTF passive policy which kicks in based on CPU passive threshold.
So, as mentioned in changelog during some corner case scenarios we are seeing the CPU temp suddenly spikes till 99C and DPTF initiates shutdown. To overcome this situation, we need this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44054
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If15a873a997aa80f20940f27bbafd4498908c091
Gerrit-Change-Number: 44054
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 31 Jul 2020 04:59:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment