6 Nov
2019
6 Nov
'19
4:03 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31323 )
Change subject: mb/asus/p5ql-em: Add mainboard ......................................................................
Patch Set 15: Code-Review+2
(1 comment)
LGTM
https://review.coreboot.org/c/coreboot/+/31323/14/src/mainboard/asus/p5ql-em... File src/mainboard/asus/p5ql-em/romstage.c:
https://review.coreboot.org/c/coreboot/+/31323/14/src/mainboard/asus/p5ql-em... PS14, Line 93: pnp_write_config(GPIO_DEV, 0xf1, old_reg | reg | 4);
What is the '| 4' here for? […]
I guess this is solved
--
To view, visit https://review.coreboot.org/c/coreboot/+/31323
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88fe9c66dae079cd7eedcc9736c5922defbc0e5a
Gerrit-Change-Number: 31323
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 06 Nov 2019 15:03:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment