Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38241 )
Change subject: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38241/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38241/1//COMMIT_MSG@8 PS1, Line 8:
So the devices were not enabled at all in the devicetree, weren’t they? Do they have to be, or would […]
Just tested, and these 16.0 / 16.2 devices are found automatically even if they aren't mentioned at devicetree. I still added them to devicetree for the information purposes (add info what's situated at 16.0 / 16.2 lines), however this fix works fine even without a devicetree change.
https://review.coreboot.org/c/coreboot/+/38241/1/src/mainboard/asus/am1i-a/K... File src/mainboard/asus/am1i-a/Kconfig:
https://review.coreboot.org/c/coreboot/+/38241/1/src/mainboard/asus/am1i-a/K... PS1, Line 40: default 10
Why does this need to be increased?
IRQ_SLOT_COUNT is an array dimension of a struct at irq_tables.c and I add one new element there.
https://review.coreboot.org/c/coreboot/+/38241/1/src/mainboard/asus/am1i-a/a... File src/mainboard/asus/am1i-a/acpi/routing.asl:
https://review.coreboot.org/c/coreboot/+/38241/1/src/mainboard/asus/am1i-a/a... PS1, Line 54: 1
Why 1 and not 2?
This is identical to the code above for USB at dev 12 and 13.