Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33361 )
Change subject: soc/intel/block/cpu: Add a MP init choice selection ......................................................................
Patch Set 2:
(4 comments)
Subrata, I just realized that a choice doesn't work well if one wants to select a specific option from the mainboard Kconfig. Currently, intel/saddlebrook does that. I'm not sure if that's necessary.
Do you think we need to be able to select things or should it be always up to the person that configures coreboot? If the latter, the choice makes sense, otherwise it would get too complex, I fear.
https://review.coreboot.org/#/c/33361/2/src/soc/intel/common/block/cpu/Kconf... File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/#/c/33361/2/src/soc/intel/common/block/cpu/Kconf... PS2, Line 56: default MP_USE_COREBOOT_NATIVE_MP_INIT if !PLATFORM_USES_FSP2_1 NB. First entry is the implicit default.
https://review.coreboot.org/#/c/33361/2/src/soc/intel/common/block/cpu/Kconf... PS2, Line 75: depends on !USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI NB. This is redundant now, wouldn't mind to keep it, though.
https://review.coreboot.org/#/c/33361/2/src/soc/intel/common/block/cpu/Kconf... PS2, Line 77: This option allows FSP to perform multiprocessor initialization. I guess the help texts should move into the choice.
https://review.coreboot.org/#/c/33361/2/src/soc/intel/common/block/cpu/Kconf... PS2, Line 81: depends on FSP_USES_MP_SERVICES_PPI NB. This is redundant now, wouldn't mind to keep it, though.