Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45288 )
Change subject: amdfwtool: Apply the change of config file to hudson
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45288/13/src/southbridge/amd/pi/hud...
File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45288/13/src/southbridge/amd/pi/hud...
PS13, Line 150: $(OPT_2AMD_PUBKEY_FILE) \
: $(OPT_2PSPBTLDR_FILE) \
: $(OPT_2SMUFWM_FILE) \
: $(OPT_2SMUFWM_FN_FILE) \
: $(OPT_2PSPRCVR_FILE) \
: $(OPT_2PUBSIGNEDKEY_FILE) \
: $(OPT_2PSPSECUREOS_FILE) \
: $(OPT_2PSPNVRAM_FILE) \
: $(OPT_2PSPSECUREDEBUG_FILE) \
: $(OPT_2PSPTRUSTLETS_FILE) \
: $(OPT_2TRUSTLETKEY_FILE) \
: $(OPT_2SMUFIRMWARE2_FILE) \
: $(OPT_2SMUFIRMWARE2_FN_FILE) \
: $(OPT_2SMUSCS_FILE) \
those seem to be undefined and might also be removed. haven't checked too closely though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45288
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id953c3e4b5c075815d4cc86bc8cd7ca0ebdf6de7
Gerrit-Change-Number: 45288
Gerrit-PatchSet: 13
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Dave Frodin
dave.frodin@se-eng.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Sep 2020 21:34:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment