Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33175 )
Change subject: northbridge/intel/sandybridge: Use C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33175/4/src/southbridge/intel/bd82x6x/early_... File src/southbridge/intel/bd82x6x/early_pch.c:
https://review.coreboot.org/#/c/33175/4/src/southbridge/intel/bd82x6x/early_... PS4, Line 241: static void pch_enable_bars(void) : { : pci_write_config32(PCH_LPC_DEV, RCBA, (uintptr_t)DEFAULT_RCBA | 1); : : pci_write_config32(PCH_LPC_DEV, PMBASE, DEFAULT_PMBASE | 1); : : pci_write_config8(PCH_LPC_DEV, ACPI_CNTL, 0x80); : : pci_write_config32(PCH_LPC_DEV, GPIO_BASE, DEFAULT_GPIOBASE | 1); : : /* Enable GPIO functionality. */ : pci_write_config8(PCH_LPC_DEV, GPIO_CNTL, 0x10); : } : : static void pch_generic_setup(void) : { : RCBA32(GCS) = RCBA32(GCS) | (1 << 5); /* No reset */ : write_pmbase16(TCO1_CNT, 1 << 11); /* halt timer */ : } : : void bootblock_pch_init(void) : { : pch_enable_bars(); : : pch_generic_setup(); : } move to `bootblock.c`?