Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32057 )
Change subject: mediatek/mt8183: modify vsim2 calibration ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32057/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32057/1//COMMIT_MSG@7 PS1, Line 7: mediatek/mt8183: modify vsim2 calibration Please be more specific in the summary. Maybe:
Calibrate vsim2 to 2.7 V
https://review.coreboot.org/#/c/32057/1//COMMIT_MSG@9 PS1, Line 9: This patch modifies vsim2 calibration to meet 2.7V 1. Please add a dot/period at the end of sentences. 2. Please add the motivation, why 2.7 V are required.
https://review.coreboot.org/#/c/32057/1/src/soc/mediatek/mt8183/include/soc/... File src/soc/mediatek/mt8183/include/soc/mt6358.h:
https://review.coreboot.org/#/c/32057/1/src/soc/mediatek/mt8183/include/soc/... PS1, Line 30: PMIC_VSIM2_ANA_CON0 = 0x1c34, Use spaces for alignment as above.