Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40404 )
Change subject: mmio: Fix failure in bit field macro when accessing >30 bits
......................................................................
Patch Set 5:
(1 comment)
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40404/3/src/include/device/mmio.h
File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/40404/3/src/include/device/mmio.h@1...
PS3, Line 145: name##_BITFIELD_SIZE
one issue here is we can't handle 32bit field with this - but I don't want to change this to (u64)1U […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40404
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3cddf9df60b83de4e21243bfde6b79729fb06ef
Gerrit-Change-Number: 40404
Gerrit-PatchSet: 5
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 Apr 2020 02:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment