Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32407 )
Change subject: soc/amd/picasso: Create picasso as a copy of stoneyridge ......................................................................
Patch Set 1:
Patch Set 1: -Code-Review
Patch Set 1:
Quite honestly, I feel like people trying to develop new platforms can't win, and I'm a long-time developer on the project. I absolutely cannot imagine coming into the community as a new person and trying to add something.
I'm trying to do the right thing here and make it easy for the coreboot community to see what's being changed. I'm trying to push early instead of doing all of the development in a closed codebase, making all the decision on my own, and then trying to push it.
From Paul's comment, I get the feeling that because the Zen processor is so different, it might not be accepted in the coreboot codebase. Why else do we need to talk about it on the mailing list.
I go to extra effort to break everything down into small pieces that can be easily reviewed, and I feel attacked for that.
We need to pick a method for accepting new chips and go with it. If you want whole files that are finished, that's fine with me. If you want to force the development to be done elsewhere, I'm fine with that too.
While I do work at Google, I'm a part of the coreboot community. I'm working at Google BECAUSE i'm a part of the community. I understand the issues. I don't like the blobs and lack of documentation either. Although it may still be going in the wrong direction I'm actively working to try to improve things.
Not sure if this was meant for me, but don't get me wrong: I would be glad to see new platforms merged in, especially on the AMD front (I don't do much non-x86). What I would not want to see is code that ends up bitrotting because nobody understands it.
I've removed my vote; I have absolutely no say on this matter.
Hi Angel, Sorry if this felt like I was attacking you, that was not my intention. I'm obviously frustrated. I totally understand that people may not agree with what I'm pushing or how I chose to push it, but I'm *TRYING* to do the right thing.
My frustration is because if I chose the other path, of pushing fully finished pieces, I'd get objections for doing it that way as well. It really seems like there's no good way to get new platforms in. I started the patch by making that comment, and I get sarcastic comments. Again, Angel, I'm not referring to your review.