Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7 ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 43: # Enable DPTF : register "dptf_enable" = "1"
Why should this be disabled?
DPTF support can be added once the board boots (I don't think it's really useful on a desktop anyway)
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 53: Display_PEG
Display_PEG means that if you use an external graphics card on your board and it is inserted into th […]
Uh, then this should indeed be Display_PEG
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... File src/mainboard/gigabyte/ga-z170x-gaming7/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/38920/13/src/mainboard/gigabyte/ga-... PS13, Line 29: DP2, -- The board's HDMI port
in vendor firmware under linux they both showed up as DP output for some reason, thats why I did it […]
@Maxim the passive DP-to-HDMI converters need HDMI to be enabled here.