Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34789 )
Change subject: mb/google/hatch/var/kindred: Disable SATA controller for eMMC SKUs
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34789/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/variant.c:
https://review.coreboot.org/c/coreboot/+/34789/2/src/mainboard/google/hatch/...
PS2, Line 33: emmc_host->enabled = 0;
Check for NULL before dereferencing
https://review.coreboot.org/c/coreboot/+/34789/2/src/mainboard/google/hatch/...
PS2, Line 38: ssd_host->enabled = 0;
Check for NULL before dereferencing
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d95ff94b079a564f74c19739370101899843f00
Gerrit-Change-Number: 34789
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 19:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment