Attention is currently required from: Eran Mitrani, Eric Lai, Jakub Czapiga, Kangheui Won, Kapil Porwal, Paul Menzel, Sumeet R Pawnikar, Tarun Tuli.
Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76835?usp=email )
Change subject: mb/google/rex: enable d3hot for storage devices
......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76835/comment/f1e49ee7_c485f321 :
PS3, Line 9: is needed to set
needs to be set
Acknowledged
https://review.coreboot.org/c/coreboot/+/76835/comment/889f8aeb_4ad4bdca :
PS3, Line 13: bypass
bypasses
Acknowledged
https://review.coreboot.org/c/coreboot/+/76835/comment/1813c4eb_a34b1eb9 :
PS3, Line 13: requirenet
requirement
Acknowledged
https://review.coreboot.org/c/coreboot/+/76835/comment/ded54aa9_4e0e3162 :
PS3, Line 13: This feature also bypass the low LTR requirenet from SSD that blocking S0i2.2 LTR soc requirement.
Please reflow for 72 characters per line.
Acknowledged
https://review.coreboot.org/c/coreboot/+/76835/comment/2093829c_698eb6c6 :
PS3, Line 15: Name (_DSD, Package () {
: ToUUID("5025030F-842F-4AB4-A561-99A5189762D0"),
: Package () {
: Package (2) {"StorageD3Enable", 1},
: // 1 - Enable; 0 - Disable
: }
: }
: )
Please use either tabs or spaces for indentation.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76835?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19decc2706954e73bc28fc2d9c3c4d18d2c384b7
Gerrit-Change-Number: 76835
Gerrit-PatchSet: 3
Gerrit-Owner: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 03 Aug 2023 16:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment