Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43628 )
Change subject: mb/system76/lemp9: Enable SA thermal device ......................................................................
Patch Set 21:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43628/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43628/6//COMMIT_MSG@9 PS6, Line 9: Tested on lemp9, SA thermal device appears in lspci
Please add a period at the end of the sentence.
Done
https://review.coreboot.org/c/coreboot/+/43628/18//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43628/18//COMMIT_MSG@9 PS18, Line 9: Tested on lemp9, SA thermal device appears in lspci.
If you add output of lspci for this particular thermal device as result here, that would be helpful.
Done
https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... PS19, Line 142: register "Device4Enable" = "1"
Please move this down to the devicetree.
Done
https://review.coreboot.org/c/coreboot/+/43628/19/src/mainboard/system76/lem... PS19, Line 195: device pci 04.0 on end # SA Thermal device
The reason to do this is that it allows one to quickly see that both settings match. […]
Done