Attention is currently required from: Felix Singer, Tim Wawrzynczak, Casper Chang.
Ariel Fang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60104 )
Change subject: mb/google/brya/var/primus:Fix some GPIO programming
......................................................................
Patch Set 14:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60104/comment/b0a4c469_abb2d0b4
PS9, Line 7: Modify the GPIO pin to none.
You are modifying multiple pads, and also adding new. […]
Done
https://review.coreboot.org/c/coreboot/+/60104/comment/c54d8279_c8df941e
PS9, Line 9: - Modify the gpio pin to none.
I think what we're getting at here is a few GPIOs were missed during the initial review, and this fi […]
done,thanks Tim.thanks Felix. 😊
Commit Message:
https://review.coreboot.org/c/coreboot/+/60104/comment/403f5c7f_3faeeaab
PS12, Line 7: Follow the schematic to modify the gpio pin to none.
suggestion: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e269bc6fb6eda7b2de57e1a9c900864d3e86e98
Gerrit-Change-Number: 60104
Gerrit-PatchSet: 14
Gerrit-Owner: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 23 Dec 2021 00:28:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment