Hello Patrick Rudolph, Wim Vervoorn, Angel Pons, Aamir Bohra, Frans Hendriks, Wonkyu Kim, Maulik V Vaghela, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38456
to look at the new patch set (#16).
Change subject: soc/intel/common/systemagent: Make northbridge.asl common ......................................................................
soc/intel/common/systemagent: Make northbridge.asl common
This patch unifies northbridge.asl based on System Agent (SA) register analysis between SKL till TGL.
Major delta are 0x48:MCHBAR and 0x60:PCIEXBAR register LENGTH offset definition has been changed for each SoC.
This change provides a new Kconfig option that can be selected by SoCs using these new bit definitions of PCIEXBAR.LENGTH and MCHBAR.
Common code takes care of setting the right value for mchbar and pciex length depending upon those Kconfig.
Additionally only reserve ACPI TPM area for !CONFIG_TPM_CR50 device.
Rename CONFIG_PCIEX_LENGTH to CONFIG_PCIEX_LENGTH_MIB to avoid ugly typecasting.
TEST=DSDT dump shows PCIEXBAR.LENGTH offset (3:1) for TGL and ICL. DSDT dump shows PCIEXBAR.LENGTH offset (2:1) for SKL and CML
Change-Id: Ifa00c4e6b872896ace975f1c6bd56c6efb172410 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/mainboard/asrock/h110m/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/razer/blade_stealth_kbl/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl M src/soc/intel/apollolake/systemagent.c M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/systemagent.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/common/block/systemagent/Kconfig M src/soc/intel/common/block/systemagent/systemagent_def.h M src/soc/intel/common/block/systemagent/systemagent_early.c M src/soc/intel/icelake/Kconfig M src/soc/intel/icelake/systemagent.c M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/acpi.c D src/soc/intel/skylake/acpi/systemagent.asl M src/soc/intel/skylake/systemagent.c M src/soc/intel/tigerlake/Kconfig M src/soc/intel/tigerlake/systemagent.c 28 files changed, 224 insertions(+), 384 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/38456/16