Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39135 )
Change subject: src/soc/tigerlake: Add memory configuration support for Jasper Lake ......................................................................
Patch Set 23:
(16 comments)
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... File src/soc/intel/tigerlake/meminit_jsl.c:
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 24: do { \
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 24: do { \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 25: memcpy(&_mem_cfg->DqByteMapCh ## _ch, \
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 25: memcpy(&_mem_cfg->DqByteMapCh ## _ch, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 26: &_b_cfg->dq_map[_ch], \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 26: &_b_cfg->dq_map[_ch], \
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 27: sizeof(_b_cfg->dq_map[_ch])); \
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 27: sizeof(_b_cfg->dq_map[_ch])); \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 28: memcpy(&_mem_cfg->DqsMapCpu2DramCh ## _ch, \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 28: memcpy(&_mem_cfg->DqsMapCpu2DramCh ## _ch, \
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 29: &_b_cfg->dqs_map[_ch], \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 29: &_b_cfg->dqs_map[_ch], \
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 30: sizeof(_b_cfg->dqs_map[_ch])); \
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 30: sizeof(_b_cfg->dqs_map[_ch])); \
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 31: } while (0)
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39135/22/src/soc/intel/tigerlake/me... PS22, Line 31: } while (0)
please, no spaces at the start of a line
Ack