Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31425 )
Change subject: qemu-q35: die if started on wrong machine
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31425/2/src/mainboard/emulation/qem...
File src/mainboard/emulation/qemu-q35/bootblock.c:
https://review.coreboot.org/c/coreboot/+/31425/2/src/mainboard/emulation/qem...
PS2, Line 47: die("You must run qemu for machine Q35");
Detect this after console_init() in romstage so it has small chance of ending up on the console.
Done
Added the same code in romstage if !CONSOLE_BOOTBLOCK.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1b24176de971c5f827091bc5bc1bac8426f3f6
Gerrit-Change-Number: 31425
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 07 Jul 2019 15:01:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment