Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35030 )
Change subject: soc/intel/skylake: Add Lewisburg family PCH support
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35030/10/src/include/device/pci_ids...
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/35030/10/src/include/device/pci_ids...
PS10, Line 3244: #define PCI_DEVICE_ID_INTEL_LWB_P2SB 0xa1a0
: #define PCI_DEVICE_ID_INTEL_LWB_P2SB_SUPER 0xa220
Ok, done
SKL should use the P2SB driver
In this case, need to add all the other IDs for skl/kbl
Thanks
https://review.coreboot.org/c/coreboot/+/35030/10/src/soc/intel/common/block...
File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/35030/10/src/soc/intel/common/block...
PS10, Line 81: PCI_DEVICE_ID_INTEL_LWB_SSATA_AHCI_SUPER,
I think that's necessary, the driver will need to have those programming even in raid mode.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35030
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7eaf2c1bb725ffed66f86c023c415ad17fe5793d
Gerrit-Change-Number: 35030
Gerrit-PatchSet: 12
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Sep 2019 10:29:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Lance Zhao
lance.zhao@gmail.com
Gerrit-MessageType: comment