Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33842 )
Change subject: src/superio/nuvoton: Add support for NCT5539D ......................................................................
Patch Set 11:
(2 comments)
Please take a look at.
https://review.coreboot.org/#/c/33842/10/src/superio/nuvoton/common/early_se... File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/#/c/33842/10/src/superio/nuvoton/common/early_se... PS10, Line 78: 0x40
this would break serial console for the nct6791
NCT6776F-D, NCT6791D and NCT5539D has the same set of values for this, so the switch code supposed to be the same as deduction indicates.
https://review.coreboot.org/#/c/33842/10/util/superiotool/nuvoton.c File util/superiotool/nuvoton.c:
https://review.coreboot.org/#/c/33842/10/util/superiotool/nuvoton.c@597 PS10, Line 597: {0x06, "Consumer IR",
please put the changes to this file in a separate patch
Will do.