Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38443 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@10 PS2, Line 10: it meet
Fits on line above.
We need 2 lines for this comment anyway, Let's not quibble about the placement of a single word.
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@11 PS2, Line 11:
What is the current error with fishbowl 1000? How much does the temperature rise?
Fishbowl is just being used to raise the temperature - Hopefully there's no error.
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@14 PS2, Line 14: check
Fits on line above.
Same as above, this is a quibble. Let's not make contributors jump through arbitrary hoops to submit changes.
https://review.coreboot.org/c/coreboot/+/38443/2/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/treeya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38443/2/src/mainboard/google/kahlee... PS2, Line 25: register "stapm_power_mw" = "7800" According to the comment, you wanted to set it to 200 seconds, but this looks like 2000 seconds or just over half an hour.