build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40798 )
Change subject: [WIP]framebuffer_info: Add new method to specify an exact pixel format ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40798/4/src/lib/framebuffer_info.c File src/lib/framebuffer_info.c:
https://review.coreboot.org/c/coreboot/+/40798/4/src/lib/framebuffer_info.c@... PS4, Line 306: switch (bpp) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/40798/4/src/lib/framebuffer_info.c@... PS4, Line 320: switch (pf) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/40798/4/src/soc/rockchip/rk3288/dis... File src/soc/rockchip/rk3288/display.c:
https://review.coreboot.org/c/coreboot/+/40798/4/src/soc/rockchip/rk3288/dis... PS4, Line 96: if (pf == PF_UNKNOWN) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/40798/4/src/soc/rockchip/rk3399/dis... File src/soc/rockchip/rk3399/display.c:
https://review.coreboot.org/c/coreboot/+/40798/4/src/soc/rockchip/rk3399/dis... PS4, Line 140: if (pf == PF_UNKNOWN) { braces {} are not necessary for single statement blocks