build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45087 )
Change subject: soc/intel/tigerlake: Add config option to enable TME ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45087/1/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45087/1/src/soc/intel/tigerlake/rom... PS1, Line 212: /* Change TmeEnable UPD value according to ENABLE_TME Kconfig */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45087/1/src/soc/intel/tigerlake/rom... PS1, Line 213: m_cfg->TmeEnable = CONFIG(INTEL_TME); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45087/1/src/soc/intel/tigerlake/rom... PS1, Line 213: m_cfg->TmeEnable = CONFIG(INTEL_TME); please, no spaces at the start of a line