Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39346 )
Change subject: soc/intel/tigerlake: Add processor power limits control support
......................................................................
Patch Set 6:
(2 comments)
Patch Set 6:
Can you add Topic as TGL_UPSTREAM
Done.
https://review.coreboot.org/c/coreboot/+/39346/5/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/39346/5/src/soc/intel/tigerlake/chi...
PS5, Line 174: psys_pmax
This isn't used anywhere; is that intentional?
We have plan to use this once closed system available.
https://review.coreboot.org/c/coreboot/+/39346/5/src/soc/intel/tigerlake/cpu...
File src/soc/intel/tigerlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/39346/5/src/soc/intel/tigerlake/cpu...
PS5, Line 218: MCH_DDR_POWER_LIMIT_LO
I don't see coreboot setting these, are these set by FSP-M?
This is the same as per other platform implementation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41fd95949aa2b02828aa2d13d29b962cb579904a
Gerrit-Change-Number: 39346
Gerrit-PatchSet: 6
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Mar 2020 15:34:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment