Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )
Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/madoo/gpio.c:
https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede...
PS3, Line 17: PAD_NC(GPP_D15, NONE),
Is Madoo using USB Camera and not using MIPI Camera?
If not using MIPI Camera, then probably need to mark CLK_24M_UCAM, CLK_24M_WCAM as NC. Also mark the I2C lines to camera as NC i.e. AP_I2C_CAM_SDA, AP_I2C_CAM_SCL as NC.
If using USB Camera is there an enable GPIO for the camera?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f
Gerrit-Change-Number: 43745
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 24 Jul 2020 07:21:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment