Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39715 )
Change subject: configs: Add builder Tioga Pass config ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39715/2/configs/builder/config.ocp.... File configs/builder/config.ocp.tiogapass:
https://review.coreboot.org/c/coreboot/+/39715/2/configs/builder/config.ocp.... PS2, Line 14: CONFIG_FSP_S_FILE="3rdparty/blobs/mainboard/ocp/tiogapass/Server_S.fd"
Instead of 3 FSP binaries, it would be easier and less error prone to do: […]
yeah that is a good idea. It is a bit weird to point out to files that do not exist but the existing definition do exactly the same ;-)