Attention is currently required from: Angel Pons.
Shawn C has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49076 )
Change subject: arch/x86/pci_io_cfg.h: Fix undefined behaviour in left-shift
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Please review it again.
File src/arch/x86/include/arch/pci_io_cfg.h:
https://review.coreboot.org/c/coreboot/+/49076/comment/4bb8dd42_e654fff3
PS2, Line 13: 1UL
`1u` is enough.
done!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6eeee1e92b616f68aa60eb74771912dd00ff7712
Gerrit-Change-Number: 49076
Gerrit-PatchSet: 3
Gerrit-Owner: Shawn C
citypw@hardenedlinux.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shawn C
citypw@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 08 Jan 2021 02:54:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment