Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39430 )
Change subject: edid_fill_fb: Add row_alignment argument
......................................................................
Patch Set 1:
(1 comment)
Somewhat con
https://review.coreboot.org/c/coreboot/+/39430/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39430/1//COMMIT_MSG@13
PS1, Line 13: Future patches will get rid of externally provided bytes_per_line.
Well... when is this gonna happen? I think it only makes sense to do this all at once, otherwise we have even more confusing redundancies floating around.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39430
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ce88193c5e324a2a7b04e0a7e3438172afca038
Gerrit-Change-Number: 39430
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 10 Mar 2020 22:37:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment