Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46326 )
Change subject: soc/amd/common: Add weak function definitions to get ioapic IDs
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG@8
PS1, Line 8:
Please elaborate, why these functions might be needed. […]
The helper function helps with the common code, that will not use the program specific Kconfig. It will give the flexibility in the future of moving more ACPI code into common without affecting the older generations.
https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG@10
PS1, Line 10: overriddden
overridden
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6778bf5141df580759e8158010a63d6af77e8ae
Gerrit-Change-Number: 46326
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Oct 2020 18:41:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment