Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43656 )
Change subject: device/cardbus: Check dev->link_list to avoid accessing garbage ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43656/2/src/device/cardbus_device.c File src/device/cardbus_device.c:
https://review.coreboot.org/c/coreboot/+/43656/2/src/device/cardbus_device.c... PS2, Line 149: printk(BIOS_ERR, "cardbus: dev->link_list is NULL\n");
Well, if link_list isn't valid, I'm not sure how the code would handle it.
It's only the 4 lines below. Not hard to read, is it? In total what this function does: * Set additional bits in the bridge control reg. * Allow `link_list->bridge_ctrl` to add some more bits. If there is no `link_list`, we can still go on as if there was one that wouldn't set more bits.