Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60129 )
Change subject: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60129/comment/8e0e8d7a_495f19f4
PS2, Line 13: when doing the autotest.
Sort of. […]
Hmmm, if it's critical pretty much depends on the hardware :)
When somebody chose the driver on purpose, failed probing would be
an error. If it's just enabled to work in case there is a controller
but not necessarily (e.g. one payload for different machines), there
would be nothing to complain about, actually.
coreboot would know if we have to expect a controller, but I guess
it doesn't tell the payload?
A better commit message would be nice. Currently it suggests to me
that the code does something wrong. However, the error seems actually
expected (depending on the hardware), so where is the test specifi-
cation and how can it be fixed? ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60129
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255
Gerrit-Change-Number: 60129
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Fri, 17 Dec 2021 00:30:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment