build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30957 )
Change subject: superio/ite: Add and use it8528e ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c File src/superio/ite/it8528e/superio.c:
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c@47 PS1, Line 47: /* Documentation: Programm io0 = 0x60 and io1 = 0x64 */ 'Programm' may be misspelled - perhaps 'Program'?
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c@51 PS1, Line 51: /* Documentation: Programm io0 = 0x70 and io1 = 0x272 */ 'Programm' may be misspelled - perhaps 'Program'?
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c@54 PS1, Line 54: /* Documentation: Programm io0 = 0x62 and io1 = 0x66 */ 'Programm' may be misspelled - perhaps 'Program'?
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c@55 PS1, Line 55: { NULL, IT8528E_PMC1, PNP_IO0 | PNP_IO1 | PNP_IRQ0 , 0x07ff, 0x07ff }, space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c@56 PS1, Line 56: { NULL, IT8528E_PMC2, PNP_IO0 | PNP_IO1 | PNP_IO2 | PNP_IRQ0 , 0x07fc, space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c@59 PS1, Line 59: { NULL, IT8528E_PMC3, PNP_IO0 | PNP_IO1 | PNP_IRQ0 , 0x07ff, 0x07ff }, space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c@60 PS1, Line 60: { NULL, IT8528E_PMC4, PNP_IO0 | PNP_IO1 | PNP_IRQ0 , 0x07ff, 0x07ff }, space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c@61 PS1, Line 61: { NULL, IT8528E_PMC5, PNP_IO0 | PNP_IO1 | PNP_IRQ0 , 0x07ff, 0x07ff }, space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/#/c/30957/1/src/superio/ite/it8528e/superio.c@63 PS1, Line 63: { NULL, IT8528E_PECI, PNP_IO0 , 0xfff8 }, space prohibited before that ',' (ctx:WxW)