Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32858 )
Change subject: console: Move poor-man's atoi() into string.h ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
I agree with Paul that the comment formatting needs polishing.
https://review.coreboot.org/#/c/32858/3/src/include/string.h File src/include/string.h:
https://review.coreboot.org/#/c/32858/3/src/include/string.h@182 PS3, Line 182: a positive integer
Okay, I'll say unsigned.
Done
https://review.coreboot.org/#/c/32858/3/src/include/string.h@183 PS3, Line 183:
Added details.
Done
https://review.coreboot.org/#/c/32858/3/src/include/string.h@184 PS3, Line 184: static inline
Let me do that in a separate CL since it gets a bit more complicated with Makefiles and stuff (and t […]
It's clear that LTO doesn't have a huge impact on boot time or code size. Yet, it enables more freedom for the toolchain regarding inlining and removes a need to put definitions of functions into headers for them to be suitable for inlining.
Sure, Identical Code Folding is supposed to collapse all the instantiations of such header-defined static functions. It's ugly but acceptable.