[coreboot-gerrit] Change in ...coreboot[master]: util/inteltool: Improve GPIO specification

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31634 )

Change subject: util/inteltool: Improve GPIO specification
......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/#/c/31634/12/util/inteltool/gpio.h 
File util/inteltool/gpio.h:

https://review.coreboot.org/#/c/31634/12/util/inteltool/gpio.h@60 
PS12, Line 60: 	uint32_t config[2];
Please move into a separate commit along with the intended code changes.

https://review.coreboot.org/#/c/31634/10/util/inteltool/gpio_test.h 
File util/inteltool/gpio_test.h:

https://review.coreboot.org/#/c/31634/10/util/inteltool/gpio_test.h@24 
PS10, Line 24: .name
> I think the brackets make it more messy. […]

Most pads would fit a single line (increase readabitity, IMHO) if we'd
leave out the identifiers. e.g.

{ "GPP_A1",     GPIO,   { { 1, "LAD0" }, { 3, "ESPI_IO0" } } },