build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45386 )
Change subject: nb/intel/pineview: Guard DMIBAR/EPBAR macro parameters ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45386/1/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/pineview.h:
https://review.coreboot.org/c/coreboot/+/45386/1/src/northbridge/intel/pinev... PS1, Line 62: #define EPBAR8(x) *((volatile u8 *)(DEFAULT_EPBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45386/1/src/northbridge/intel/pinev... PS1, Line 63: #define EPBAR16(x) *((volatile u16 *)(DEFAULT_EPBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45386/1/src/northbridge/intel/pinev... PS1, Line 64: #define EPBAR32(x) *((volatile u32 *)(DEFAULT_EPBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45386/1/src/northbridge/intel/pinev... PS1, Line 70: #define DMIBAR8(x) *((volatile u8 *)(DEFAULT_DMIBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45386/1/src/northbridge/intel/pinev... PS1, Line 71: #define DMIBAR16(x) *((volatile u16 *)(DEFAULT_DMIBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45386/1/src/northbridge/intel/pinev... PS1, Line 72: #define DMIBAR32(x) *((volatile u32 *)(DEFAULT_DMIBAR + (x))) Macros with complex values should be enclosed in parentheses