Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46855 )
Change subject: mrc_cache: Move code for triggering memory training into mrc_cache
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46855/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46855/6//COMMIT_MSG@11
PS6, Line 11: Moving the code that makes this decision into the mrc_cache.
This sentence comes a little unmotivated for me. Maybe (if correct):
As this is not platform specific, but uses common vboot infrastructure, the code can be unified and moved into mrc_cache.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3875a7b4a4ba3c1aa8a3c1507b3993036a7155fc
Gerrit-Change-Number: 46855
Gerrit-PatchSet: 6
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Nov 2020 20:39:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment