Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39221 )
Change subject: vboot: Clean up pre-RAM use of vboot_recovery_mode_enabled()
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39221/2/src/drivers/intel/fsp1_1/Kc...
File src/drivers/intel/fsp1_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/39221/2/src/drivers/intel/fsp1_1/Kc...
PS2, Line 16: depends on !VBOOT_STARTS_IN_BOOTBLOCK
AFAIK, the only SoC that uses FSP 1.1 is Braswell, and none of the Braswell boards select VBOOT_STARTS_IN_BOOTBLOCK
The CAR setup of FSP1.1 Braswell is not large enough for the vboot2_work buffer, so there is not much to do about that. There is no other FSP1.1 platform supported atm, but vboot was supported in bootblock on FSP1.1 Skylake (deprecated). There does not seem to exist other FSP1.1 platforms besides these two.
So this change does not hurt, but it's a bit weird.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31bfc7663724fdacab9955224dcaf650d1ec1c3c
Gerrit-Change-Number: 39221
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Apr 2020 10:01:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment