[coreboot-gerrit] Change in coreboot[master]: x86/smp/spinlock: Disable thread coop when taking spinlock

[Julius Werner (Code Review)]

Attention is currently required from: Raul Rangel, Furquan Shaikh.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56320 )

Change subject: x86/smp/spinlock: Disable thread coop when taking spinlock
......................................................................

Patch Set 1:

(1 comment)

File src/arch/x86/include/arch/smp/spinlock.h:

https://review.coreboot.org/c/coreboot/+/56320/comment/14bfe7c3_cd536bb8 
PS1, Line 61: 	lock->coop = thread_coop_enabled();
> So I had the same thought as your did about storing it in the thread structure, but there is only 1  […]

Oh... hmm... yeah okay, that's a fair point. I still think the semaphore approach is much better though, because like I said there will probably be other situations with the same fundamental problem, and it's better to just solve them all in one go.