Nico Huber has posted comments on this change. ( https://review.coreboot.org/27204 )
Change subject: nb/intel/i945: Remove dead code when channel B is empty ......................................................................
Patch Set 7: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/27204/7/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/27204/7/src/northbridge/intel/i945/raminit.c... PS7, Line 1201: /* If Channel 1 is not populated. C1DRB are equal to C0DRB3 */ I hate comments.
The old comment, with the `#if 0` in mind, at least told us that somebody expected it should be set to 0 (maybe because some docu- mentation told him so), but somehow it didn't work.
The new comment, OTOH, makes the impression that it is supposed to be like the code currently does and that the author knew what he was doing. Which makes it worse than not commenting at all. I even doubt that it adds any value.
So please, no new comment, or leave everything as it is.