Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31490 )
Change subject: soc/amd/common: Refactor S3 helpers
......................................................................
Patch Set 6:
This file is just misplaced under soc/ when it is common to AGESAv5. While named s3_resume, functionality of storing non-volatile section and use it for cold boots is used with family16kb.
For the record; I shall be blocking attempts to place AGESAv9 (?) support code elsewhere other than under src/drivers/amd/. We have established directory layout with FSP, follow it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31490
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1506ee2f7ecf3cb6ec4cce37a030c05f78ec6d59
Gerrit-Change-Number: 31490
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 18 Jul 2019 01:57:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment