build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: [WIP]amdfwtool: Take a config file instead of command line parameters ......................................................................
Patch Set 1:
(100 comments)
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.c@... PS1, Line 583: printf (" filename=%s\n", index->filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.c@... PS1, Line 594: printf (" filename=%s\n", index->filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.c@... PS1, Line 979: static const char *optstring = "x:i:g:AMS:p:b:s:r:k:c:n:d:t:u:w:m:T:z:J:B:K:L:Y:N:UW:I:a:Q:V:e:v:j:y:G:O:X:F:H:o:f:l:hZ:qR:P:C"; line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1110: config_file = malloc (fd_stat.st_size+1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1420: if (configfd >=0) { spaces required around that '>=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1431: close (configfd); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh File util/amdfwtool/amdfwtool.sh:
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 4: # --bootloader /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//PspBootLoader_prod_RV.sbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 5: # --rtmpubkey /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//RtmPubSignedRV.key \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 6: # --secureos /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//psp_os_combined_prod_RV.sbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 7: # --securedebug /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//RavenSecureDebug_PublicKey.bin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 9: # --trustlets /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//dr_ftpm_prod_RV.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 10: # --subprogram 2 --smufirmware /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//SmuFirmwarePCO.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 11: # --subprogram 2 --smufirmware2 /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//SmuFirmware2PCO.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 12: # --subprogram 1 --smufirmware /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//SmuFirmwareRV2.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 13: # --subprogram 1 --smufirmware2 /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//SmuFirmware2RV2.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 16: # --subprogram 0 --instance 1 --pmu-inst /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//Appb_Rv_1D_Ddr4_Udimm_Imem.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 17: # --subprogram 0 --instance 4 --pmu-inst /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//Appb_Rv_2D_Ddr4_Imem.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 18: # --subprogram 1 --instance 1 --pmu-inst /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//Appb_Rv2_1D_ddr4_Udimm_Imem.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 19: # --subprogram 1 --instance 4 --pmu-inst /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//Appb_Rv2_2D_ddr4_Udimm_Imem.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 20: # --subprogram 0 --instance 1 --pmu-data /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//Appb_Rv_1D_Ddr4_Udimm_Dmem.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 21: # --subprogram 0 --instance 4 --pmu-data /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//Appb_Rv_2D_Ddr4_Dmem.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 22: # --subprogram 1 --instance 1 --pmu-data /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//Appb_Rv2_1D_ddr4_Udimm_Dmem.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 23: # --subprogram 1 --instance 4 --pmu-data /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//Appb_Rv2_2D_ddr4_Udimm_Dmem.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 24: # --mp2-config /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//MP2FWConfig.sbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 25: # --abl-image /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//AgesaBootloader0_prod_RV.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 26: # --abl-image /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//AgesaBootloader1_prod_RV.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 27: # --abl-image /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//AgesaBootloader2_prod_RV.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 28: # --abl-image /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//AgesaBootloader3_prod_RV.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 29: # --abl-image /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//AgesaBootloader4_prod_RV.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 30: # --abl-image /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//AgesaBootloader5_prod_RV.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 31: # --abl-image /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//AgesaBootloader6_prod_RV.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 32: # --abl-image /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//AgesaBootloader7_prod_RV.csbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 33: # --subprog 1 --sec-gasket /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//security_policy_RV2_FP5_AM4.sbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 34: # --subprog 2 --sec-gasket /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//security_policy_PCO_FP5_AM4.sbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 35: # --subprog 1 --mp2-fw /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//MP2I2CFWRV2.sbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 36: # --subprog 2 --mp2-fw /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//MP2I2CFWPCO.sbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 37: # --drv-entry-pts /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//drv_sys_prod_RV.sbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 38: # --ikek /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//PspIkekRV.bin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/amdfwtool.sh... PS1, Line 39: # --secdebug /home/baozheng/x86/coreboot-gerrit/3rdparty/blobs/soc/amd/picasso/PSP//secure_unlock_prod_RV.sbin \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 10: "(^[[:space:]]*$)" "|" /* or ... */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 10: "(^[[:space:]]*$)" "|" /* or ... */ Consecutive strings are generally better as a single string
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 12: "(^[[:space:]]*" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 14: "#.*$)"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 19: "^[[:space:]]*" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 21: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 23: "[[:space:]]+" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 25: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 27: "[[:space:]]*$"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 32: "^[[:space:]]*" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 34: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 36: "[[:space:]]+" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 38: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 40: "[[:space:]]+" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 42: "([^[:space:]]+)" please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 44: "[[:space:]]*$"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 53: if ((result = regcomp(reg, expr, cflags)) != 0) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 75: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 83: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 91: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 98: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 105: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 112: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 119: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 126: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 133: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 140: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 147: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 154: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 161: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 168: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 175: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 182: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 189: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 196: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 203: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 210: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 217: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 224: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 231: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 238: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 245: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 252: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 259: entry_size = sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 276: } else { else is not generally useful after a break or return
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 326: //printf("%x,%x,%x\n", *(unsigned int *)tableptr, ((amd_bios_entry *)tableptr)->subpr, ((amd_bios_entry *)tableptr)->inst); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 337: tableptr += sizeof (amd_bios_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 342: if (strcmp(fw_name, "PSP_SOFTFUSE") == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 352: printf("%x,%x,%x\n", *(unsigned int *)tableptr, ((amd_bios_entry *)tableptr)->subpr, ((amd_bios_entry *)tableptr)->inst); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 356: ((amd_fw_entry *)tableptr)->other = strtoull(filename, NULL, 16); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 361: tableptr += sizeof (amd_fw_entry); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 379: if (*ptr == NULL) return -1; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 382: while (*ptr != '\n' && *ptr != NULL) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 383: ptr ++; space prohibited before that '++' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 389: memcpy (*oneline, line_start, num); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 391: ptr ++; /* skip enter. */ space prohibited before that '++' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 405: compile_reg_expr(REG_EXTENDED | REG_NEWLINE, blank_or_comment_regex, &blank_or_comment_expr); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 407: compile_reg_expr(REG_EXTENDED | REG_NEWLINE, entries_subprog_line_regex, &entries_subprog_line_expr); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 419: if (!regexec(&blank_or_comment_expr, oneline, 0, NULL, 0)){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 433: printf("%d, %d, %d\n", match[0].rm_eo, match[1].rm_eo, match[2].rm_eo, match[3].rm_eo); line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/1/util/amdfwtool/data_parse.c... PS1, Line 434: printf("%d, %d, %d\n", match[0].rm_so, match[1].rm_so, match[2].rm_so, match[3].rm_so); line over 96 characters