Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85967?usp=email )
Change subject: soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85967/comment/7d801753_e94f8b75?usp... :
PS1, Line 7: Mitigatation for the second call to mtXXXX_init_pmif_arb
How about `Skip duplicate pmif_arb->is_pmif_init_done() call`
Done
File src/soc/mediatek/common/mt6685.c:
https://review.coreboot.org/c/coreboot/+/85967/comment/be0c0c5a_40e5cd3b?usp... :
PS1, Line 86: if (!pmif_arb) {
remove
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85967?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id1d11f8b238855edb393d77151159792e7716d22
Gerrit-Change-Number: 85967
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 14 Jan 2025 11:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com