Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35533 )
Change subject: mb/google/hatch: Support separate fixed PL1 setting for tablet mode ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35533/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35533/1//COMMIT_MSG@9 PS1, Line 9: thier their
https://review.coreboot.org/c/coreboot/+/35533/1/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/35533/1/src/ec/google/chromeec/acpi... PS1, Line 381: EC_ENABLE_MAINBOERD_TABLET_MODE_EVENT EC_ENABLE_MAINBOARD_TABLET_MODE_EVENT?
https://review.coreboot.org/c/coreboot/+/35533/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/35533/1/src/mainboard/google/hatch/... PS1, Line 22: EC_ENABLE_MAINBOERD_TABLET_MODE_EVENT EC_ENABLE_MAINBOARD_TABLET_MODE_EVENT?