Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45850 )
Change subject: soc/intel/xeon_sp: Move common northbridge ACPI to nb_acpi.c
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45850/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45850/5//COMMIT_MSG@12
PS5, Line 12: and CSTACKS that are managed with #if (CONFIG(SOC_INTEL_*_SP)).
Maybe try to convince Intel to have SKX FSP use the same API as CPX FSP?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47ab1df3474d18643ef5ffc8199e09ea3dd32ccf
Gerrit-Change-Number: 45850
Gerrit-PatchSet: 5
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 08:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment