9 Dec
2020
9 Dec
'20
12:01 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )
Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48222/6/src/drivers/i2c/tpm/Kconfig File src/drivers/i2c/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/48222/6/src/drivers/i2c/tpm/Kconfig... PS6, Line 44: bool "Generate I2C TPM ACPI device" if I2C_TPM This change made me wonder, why does it have a prompt? It seems it is either required for a successful build or not used at all?
--
To view, visit https://review.coreboot.org/c/coreboot/+/48222
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55
Gerrit-Change-Number: 48222
Gerrit-PatchSet: 6
Gerrit-Owner: Jes Klinke jbk@chromium.org
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Wed, 09 Dec 2020 20:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment