[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size

[Felix Held (Code Review)]

Attention is currently required from: Furquan Shaikh, Marshall Dawson, Meera Ravindranath, Andrey Petrov, Patrick Rudolph, Felix Held.
Hello Justin Frodsham, build bot (Jenkins), Furquan Shaikh, Marshall Dawson, Meera Ravindranath, Subrata Banik, Andrey Petrov, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/50241

to look at the new patch set (#4).

Change subject: drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size
......................................................................

drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size

If the UPD size in coreboot sizes mismatches the one from the FSP-M
binary, we're running into trouble. If the expected size is smaller than
the UPD size the FSP provides, call die(), since the target buffer isn't
large enough so only the beginning of the UPD defaults from the FSP will
get copied into the buffer. We ran into the issue in soc/amd/cezanne,
where the UPD struct in coreboot was smaller than the one in the FSP, so
the defaults didn't get completely copied.

TEST=Mandolin still boots.

Signed-off-by: Felix Held 
Change-Id: Ia7e9f6f20d0091bbb4abfd42abb40b485da2079d
---
M src/drivers/intel/fsp2_0/memory_init.c
1 file changed, 17 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/50241/4