Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52952 )
Change subject: soc/amd/common/espi: Print set eSPI peripheral config ......................................................................
soc/amd/common/espi: Print set eSPI peripheral config
This will print the config we are setting on the eSPI peripheral.
e.g., Setting general configuration: slave: 0x98a00000 controller: 0xe2000000 eSPI Slave configuration: CRC checking enabled Dedicated Alert# used to signal alert event eSPI quad IO mode selected Only eSPI single IO mode supported Alert# pin is open-drain eSPI 33MHz selected eSPI up to 20MHz supported Maximum Wait state: 0
BUG=b:187122344, b:186135022 TEST=Boot guybrush
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I1a2382d8ab3d3f0d14a139c57470cb895112eca9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52952 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 7752eb5..ade1aaa 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -705,6 +705,8 @@ printk(BIOS_INFO, "Setting general configuration: slave: 0x%x controller: 0x%x\n", slave_config, ctrlr_config);
+ espi_show_slave_general_configuration(slave_config); + if (espi_set_configuration(ESPI_SLAVE_GENERAL_CFG, slave_config) == -1) return -1;