22 Feb
2019
22 Feb
'19
6:59 a.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31357 )
Change subject: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware ......................................................................
Patch Set 3: Code-Review+1
Normally, payloads are compressed, so the 19 KiB are even reduced more. The downside of diverting from defaults is, that you cannot just share the payload with other people/systems. And it is always a question, if the added complexity is worth it.
Anyway, could you please add the size differences to the commit message?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31357
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b2ee6403d7d2298725729d8d833e37627a4f202
Gerrit-Change-Number: 31357
Gerrit-PatchSet: 3
Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com
Gerrit-Comment-Date: Fri, 22 Feb 2019 14:59:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment